Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run CI on all PR branches #282

Merged
merged 4 commits into from
Nov 21, 2024
Merged

run CI on all PR branches #282

merged 4 commits into from
Nov 21, 2024

Conversation

andrewkolos
Copy link
Contributor

This is a follow-up to #280 (comment). In summary, we only run CI checks on PRs against the main branch. However, in cases where an older major version of a package needs to be patched, it doesn't make sense to PR against main. CI won't run for these PRs, but it probably should.

This updates our GitHub CI configs to run checks against PRs against any branch.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Jun 25, 2024
@github-actions GitHub Actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:unified_analytics 6.1.2 ready to publish unified_analytics-v6.1.2
package:cli_config 0.2.0 already published at pub.dev
package:extension_discovery 2.0.1-wip WIP (no publish necessary)
package:graphs 2.3.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@andrewkolos andrewkolos marked this pull request as ready for review June 25, 2024 22:29
@andrewkolos andrewkolos requested a review from devoncarew June 25, 2024 22:29
devoncarew
devoncarew reviewed Jun 26, 2024
View reviewed changes
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! lgtm modulo the change to the publishing workflow file.

.github/workflows/publish.yaml Outdated Show resolved Hide resolved
@andrewkolos andrewkolos requested a review from devoncarew June 26, 2024 02:29
@andrewkolos
Copy link
Contributor Author

FYI: I've created a release for unified_analytics-v6.1.2 since it looks like that never got made after #277 merged. I did this as I didn't want this PR merging to trigger a release from CI.

christopherfujino
christopherfujino approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️ 
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/bazel_worker/benchmark/benchmark.dart
pkgs/bazel_worker/example/client.dart
pkgs/bazel_worker/example/worker.dart
pkgs/bazel_worker/lib/src/worker_protocol.pb.dart
pkgs/benchmark_harness/integration_test/perf_benchmark_test.dart
pkgs/boolean_selector/example/example.dart
pkgs/clock/lib/clock.dart
pkgs/clock/lib/src/clock.dart
pkgs/clock/lib/src/default.dart
pkgs/clock/lib/src/stopwatch.dart
pkgs/clock/lib/src/utils.dart
pkgs/clock/test/clock_test.dart
pkgs/clock/test/default_test.dart
pkgs/clock/test/stopwatch_test.dart
pkgs/clock/test/utils.dart
pkgs/html/example/main.dart
pkgs/html/lib/dom.dart
pkgs/html/lib/dom_parsing.dart
pkgs/html/lib/html_escape.dart
pkgs/html/lib/parser.dart
pkgs/html/lib/src/constants.dart
pkgs/html/lib/src/encoding_parser.dart
pkgs/html/lib/src/html_input_stream.dart
pkgs/html/lib/src/list_proxy.dart
pkgs/html/lib/src/query_selector.dart
pkgs/html/lib/src/token.dart
pkgs/html/lib/src/tokenizer.dart
pkgs/html/lib/src/treebuilder.dart
pkgs/html/lib/src/utils.dart
pkgs/html/test/dom_test.dart
pkgs/html/test/parser_feature_test.dart
pkgs/html/test/parser_test.dart
pkgs/html/test/query_selector_test.dart
pkgs/html/test/selectors/level1_baseline_test.dart
pkgs/html/test/selectors/level1_lib.dart
pkgs/html/test/selectors/selectors.dart
pkgs/html/test/support.dart
pkgs/html/test/tokenizer_test.dart

@coveralls
Copy link

coveralls commented Nov 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11959091177

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 11874419145: 0.0%
Covered Lines: 252
Relevant Lines: 252
💛 - Coveralls

@auto-submit auto-submit bot merged commit 466bb19 into main Nov 21, 2024
28 checks passed
@auto-submit auto-submit bot deleted the have-ci-checks-run-for-all-PR-branches branch November 21, 2024 18:11
andrewkolos added a commit that referenced this pull request Nov 21, 2024
@andrewkolos
run CI on all PR branches (#282)
dfb41c2 
This is a follow-up to #280 (comment). In summary, we only run CI checks on PRs against the main branch. However, in cases where an older major version of a package needs to be patched, it doesn't make sense to PR against main. CI won't run for these PRs, but it probably should.

This updates our GitHub CI configs to run checks against PRs against any branch.

---

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before creating a PR.
- Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`.
- Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change).
- Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing).

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@devoncarew devoncarew devoncarew approved these changes

Assignees
No one assigned
Labels
autosubmit type-infra A repository infrastructure change or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewkolos @coveralls @devoncarew @christopherfujino